Skip to content

adding h_nelec_sed and h_e_sed to SRTrueCaloPoint for better recombination studies - #182

Draft
sungbinoh wants to merge 2 commits into
SBNSoftware:developfrom
sungbinoh:feature/SRTrueCaloPoint_sed_true
Draft

adding h_nelec_sed and h_e_sed to SRTrueCaloPoint for better recombination studies#182
sungbinoh wants to merge 2 commits into
SBNSoftware:developfrom
sungbinoh:feature/SRTrueCaloPoint_sed_true

Conversation

@sungbinoh

Copy link
Copy Markdown
Contributor

Quick checklist

  • [ V ] Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
  • If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • [ V ] Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
  • [ V ] If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?

Description

Adding h_nelec_sed and h_e_sed to SRTrueCaloPoint for better recombination studies.
These variables will save deposited energy and number of ionizing electrons collected from simEnergyDeposit within wire channel position +- spacing/2. They correspond to the true deposited energy and number of ionizing electrons in the hit pitch.

@kjplows kjplows moved this to PR in progress in SBN software development Jan 15, 2026
@sungbinoh
sungbinoh marked this pull request as ready for review January 26, 2026 16:36
@sungbinoh sungbinoh self-assigned this Jan 26, 2026
@sungbinoh
sungbinoh requested a review from henrylay97 January 26, 2026 16:38
@sungbinoh
sungbinoh marked this pull request as draft January 26, 2026 16:42
@sungbinoh
sungbinoh removed the request for review from henrylay97 January 26, 2026 16:42

@henrylay97 henrylay97 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks worth doing, thanks Sungbin!

One tiny comment about typos :)

I'll wait until the PR is not-draft to approve, I assume there are complementary PRs coming in other repositories?

Comment on lines +19 to +20
float h_nelec_sed; //!< number of electrons from simEnergyDeposit (sed) in wire z +- (wire spacig) / 2, for sed overlapping with the boarder, overlaping fraction is multiplied
float h_e_sed; //!< deposited energy [MeV] from simEnergyDeposit (sed) in wire z +- (wire spacig) / 2, for sed overlapping with the boarder, overlaping fraction is multiplied

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos in the comments: spacig-->spacing and boarder-->border

@sungbinoh

sungbinoh commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Looks worth doing, thanks Sungbin!

One tiny comment about typos :)

I'll wait until the PR is not-draft to approve, I assume there are complementary PRs coming in other repositories?

Hi @henrylay97 , thank you for the review. I've fixed the typos!

I have a working version of sbncode (link) for the new variables but it works only for SBND.
I use wire position only in Z-coordinate for selecting SED corresponding to a wire channel.
It works for SBND's collection plane but not for any of ICARUS's plane.
This is main reason why I have changed this PR to draft.
I hope to get some time to develop on generality of the custom sbncode development.

@kjplows kjplows moved this from Todo to In Progress in PR archaeology Feb 11, 2026
@PetrilloAtWork
PetrilloAtWork self-requested a review July 8, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress
Status: PR in progress

Development

Successfully merging this pull request may close these issues.

3 participants