fix: implement resolution of javascript non-pnpm dependencies#47
Open
zilosz wants to merge 2 commits into
Open
fix: implement resolution of javascript non-pnpm dependencies#47zilosz wants to merge 2 commits into
zilosz wants to merge 2 commits into
Conversation
Signed-off-by: zilosz <mfecko@purdue.edu>
Signed-off-by: zilosz <mfecko@purdue.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
Description
Projects using non-pnpm Javascript package managers, namely npm and yarn, had dependencies in
node_modulesreported as "remaining files" in the SBOM rather than as packages.This PR makes it so such dependencies are accurately parsed as packages by the resolver. They now are reported as unversioned packages in the SBOM.
Changes Made
pkg/resolver/javascript.go:Expanded regex matching to capture packages in non-pnpm
node_moduleslayouts. If a file's information cannot be extracted when treated as a pnpm package, we use standard non-pnpm extraction as a fallback option.Testing
I ran sbomit on two Javascript projects with the same dependency installed: one used npm, the other pnpm. I confirmed that the resulting SBOMs reflected the behavior described above.