Address OOM risk in witness parsing#48
Open
IITI-tushar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tushar Saxena <019saxenatushar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers #41
This pull request refactors the way witness files and data are parsed in the
pkg/attestation/parser.gofile. The main improvement is the introduction of a unified parsing function that works with anyio.Reader, which simplifies handling both files and in-memory data. The code now also checks for trailing JSON and improves error handling for malformed input.Refactoring and improved parsing logic:
parseWitnessReaderfunction that parses attestation data from anyio.Reader, allowing both file-based and in-memory parsing to share the same logic. (pkg/attestation/parser.go)ParseWitnessFileandParseWitnessDatato use the newparseWitnessReaderfunction, reducing code duplication and improving maintainability. (pkg/attestation/parser.go)Robustness and error handling:
pkg/attestation/parser.go)pkg/attestation/parser.go)