Skip to content

Refactoring ros4hc_msgs#13

Open
moperezs wants to merge 2 commits intomainfrom
feature/refactor_msgs
Open

Refactoring ros4hc_msgs#13
moperezs wants to merge 2 commits intomainfrom
feature/refactor_msgs

Conversation

@moperezs
Copy link
Copy Markdown
Collaborator

@moperezs moperezs commented Jun 11, 2025

  • [Monica] 1 common Info msg for DeviceInfo.msg
  • [Monica] Renamed specific header to “...Info.msg”
  • [Monica] Added Mood.msg with Enum with possible moods.
  • [Monica] Removed time_signal_recorded → this should be the timestamp of the ros header.
  • [Monica] I would argue we only need to know when the signal was recorded, not when ROS received it and stamped the msg, in which scenario would we need this information?
  • [Monica] Renamed Pose.msg to BodyLocation.msg (to comply with mHealth)
  • [Monica] Changed from PoseStamped to Pose and added a header in Pose.msg (BodyLocation).
  • [Monica] Removed PressureHeader.msg (same as DeviceInfo.msg).
  • [Monica] Removed ElevationAngle.msg → Use PlaneAngle unit value instead (to comply with mHealth).
  • [Monica] Renamed Pressure.msg to PressureMat.msg → changed msg structure
  • [Monica] Changed Force.msg to geometry_msgs/Vector3.
  • [Monica] Added standard headers to all signals.
  • [Monica] Removed Filter.msg and added most common filters instead:
    Low pass, High Pass, Band Pass, Butterworth, Kalman, Moving average, Savitzky Golay
  • [Monica] Changed some variable names, description and added enums.
  • [Monica] Fixed CMake

Copy link
Copy Markdown
Member

@praanjalmishra praanjalmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the new structure and changes, I believe adding a README to the message org and design conventions would be helpful.

geometry_msgs/Pose waist
geometry_msgs/Pose r_hip
geometry_msgs/Pose r_knee
geometry_msgs/Pose e_ankle
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
geometry_msgs/Pose e_ankle
geometry_msgs/Pose r_ankle

@@ -0,0 +1,5 @@
std_msgs/Header header

uint32 window_length # Must be odd
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uint32 window_length # Must be odd
uint32 window_size # Must be odd

@@ -0,0 +1 @@
float32 deg # in radians
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float32 deg # in radians - field name and unit contradict each other


rosidl_generate_interfaces(${PROJECT_NAME}
${msg_files}
DEPENDENCIES std_msgs builtin_interfaces
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEPENDENCIES std_msgs builtin_interfaces
DEPENDENCIES std_msgs builtin_interfaces geometry_msgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants