Conversation
Member
praanjalmishra
left a comment
There was a problem hiding this comment.
Given the new structure and changes, I believe adding a README to the message org and design conventions would be helpful.
| geometry_msgs/Pose waist | ||
| geometry_msgs/Pose r_hip | ||
| geometry_msgs/Pose r_knee | ||
| geometry_msgs/Pose e_ankle |
Member
There was a problem hiding this comment.
Suggested change
| geometry_msgs/Pose e_ankle | |
| geometry_msgs/Pose r_ankle |
| @@ -0,0 +1,5 @@ | |||
| std_msgs/Header header | |||
|
|
|||
| uint32 window_length # Must be odd | |||
Member
There was a problem hiding this comment.
Suggested change
| uint32 window_length # Must be odd | |
| uint32 window_size # Must be odd |
| @@ -0,0 +1 @@ | |||
| float32 deg # in radians | |||
Member
There was a problem hiding this comment.
float32 deg # in radians - field name and unit contradict each other
|
|
||
| rosidl_generate_interfaces(${PROJECT_NAME} | ||
| ${msg_files} | ||
| DEPENDENCIES std_msgs builtin_interfaces |
Member
There was a problem hiding this comment.
Suggested change
| DEPENDENCIES std_msgs builtin_interfaces | |
| DEPENDENCIES std_msgs builtin_interfaces geometry_msgs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low pass, High Pass, Band Pass, Butterworth, Kalman, Moving average, Savitzky Golay