Add subscription renewal notice guard#408
Open
charlie12520 wants to merge 2 commits into
Open
Conversation
Author
|
Follow-up quality pass pushed in
Revalidated after the follow-up:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #20
Summary:
subscription-renewal-notice-guard/revenue-infrastructure slice for issue Revenue Infrastructure #20.Acceptance criteria reviewed:
/attempt #20,/claim #20, and a short demo video./attempt #20was posted before implementation, this body includes/claim #20, andreports/demo.mp4is included.CONTRIBUTING.mdexists in this repository; the issue body and Algora instructions were used as the governing guidelines.Validation:
cd subscription-renewal-notice-guard && npm run check-> passedcd subscription-renewal-notice-guard && npm test-> subscription-renewal-notice-guard tests passedcd subscription-renewal-notice-guard && npm run demo-> generated JSON/Markdown/SVG artifacts; statushold_renewals, blockers8, warnings2cd subscription-renewal-notice-guard && npm run demo:video-> generatedreports/demo.mp4git diff --checkandgit diff --cached --check-> passed before commitSafety: