Upgrade to Dart 3 (Flutter 3?) and packages to latest major versions#7
Draft
needlesslygrim wants to merge 2 commits intoSCIEDEV:mainfrom
Draft
Upgrade to Dart 3 (Flutter 3?) and packages to latest major versions#7needlesslygrim wants to merge 2 commits intoSCIEDEV:mainfrom
needlesslygrim wants to merge 2 commits intoSCIEDEV:mainfrom
Conversation
- Fixed problems with DropdownButton2 in `lib/components/button.dart` - Tried to match behaviour off old version, might not be 100% correct - Update generated linux bindings Signed-off-by: Erick Howard <needlesslygrim@proton.me>
needlesslygrim
commented
Jun 23, 2024
| .toList(), | ||
| value: selectedValue.isEmpty ? null : selectedValue.last, | ||
| selectedItemHighlightColor: MColors.transparent, | ||
| // FIXME: Fix this |
Member
Author
There was a problem hiding this comment.
@micfong-z Can you review this, I'm not sure what it did
needlesslygrim
commented
Jun 23, 2024
| child: DropdownButton2( | ||
| isExpanded: true, | ||
| scrollbarAlwaysShow: true, | ||
| // FIXME: Fix this: |
Member
Author
There was a problem hiding this comment.
This was also something I wasn't sure about
Signed-off-by: Erick Howard <needlesslygrim@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to Dart 3 ( Flutter 3? ) and update Dart code to reflect update, e.g. using
Iterable.indexedinstead of index-based for loops. A few issues arose when upgradingDropdownButton2, but I think(?) I've resolved most of those...