Update capstone test utils to use pcu::PCU object#469
Merged
Conversation
- test/capCheckParam.cc(main): replace PCU_Comm_Init with new pcu::PCU object. - test/capGeomTest.cc(main): replace static object and scoping with dynamic new/delete (explicit scoping). - update calls to use pointer instead of address-of static object. - test/cap_closestPoint.cc(main): replace PCU_Comm_Init with new pcu::PCU object. - test/cap_inClosureOf.cc(main): use new pcu::PCU object. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
cwsmith
approved these changes
Jan 19, 2025
Contributor
|
/runtests |
|
Build Log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update capstone test utils to use pcu::PCU object
This PR updates Capstone tests to use the new
pcu::PCUobject. Some of the tests were missed by the original PR #433 because they were moved fromcapstone_clis/intotest/. I chose to usenew/deleteinstead of the static object scoping because it allowed for fine-grained explicit control i.e. droppingnew pcu::PCU(MPI_COMM_WORLD)in place ofMPI_Comm_Init()anddelete PCUObjin place ofMPI_Comm_Free.