maRefine.cc: report post-refinement element quality (diagnostic only)#525
Open
como2099 wants to merge 1 commit intoSCOREC:masterfrom
Open
maRefine.cc: report post-refinement element quality (diagnostic only)#525como2099 wants to merge 1 commit intoSCOREC:masterfrom
como2099 wants to merge 1 commit intoSCOREC:masterfrom
Conversation
…sing existing markBadQuality/unMarkBadQuality infrastructure. This will help with debugging element quality checks under certain circumstances as seen in issue SCOREC#195. No behavior change unless in verbose mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds diagnostic-only reporting of element quality after mesh refinement when verbose output is enabled.
What this does
refine(), uses existingmarkBadQuality()/unMarkBadQuality()infrastructure to count low-quality simplex elements (triangles or tets).goodQuality) in verbose mode only.Why this is useful
When adapting mixed 2D tri/quad meshes, refinement can create degenerate triangles. This change makes that behavior visible using existing quality metrics, without modifying the adaptation algorithm.
Scope
ma/maRefine.cc)Example Output
This is intended as the first step in a sequence of small PRs to improve refinement robustness for 2D mixed-element meshes.
Related context: discussion in issue #195