Resolve terminal colors from shared CSS themes#166
Merged
Conversation
SDSLeon
commented
Jun 14, 2026
SDSLeon
commented
Owner
- Fix terminal color resolution so modern CSS theme values are converted into xterm-safe colors instead of relying on brittle canvas serialization.
- Update the terminal color tests with real renderer-measured fixtures to cover both authored color strings and rasterized pixel output.
- Remove terminal-specific surface tokens from shared theme presets, tokens, and global styles so the terminal background now follows the general theme surfaces.
- Keep the terminal renderer aligned with the app theme system while avoiding invalid color formats that can break xterm rendering.
- Rasterize modern CSS colors to xterm-safe values when canvas serialization is not enough. - Remove the dedicated terminal-surface theme token and stale theme overrides. - Update terminal color tests with real renderer fixtures.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.