Conversation
- add `cliPickerTarget` and live composer state for picker routing - stage terminal input through IPC and copy sandboxed attachments locally - cover shared settings and runtime staging behavior with tests
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a11f3b08e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ): Promise<PromptSegment[] | undefined> { | ||
| if (!segments || segments.length === 0) return segments; | ||
| if (!session.adapter.capabilities.requiresWorkspaceLocalAttachments) return segments; | ||
| if (session.projectLocation.kind === "wsl") return segments; |
There was a problem hiding this comment.
For adapters with requiresWorkspaceLocalAttachments (Command Code sets this), WSL attachments still need to end up under the WSL project directory. Returning here leaves the result from rewriteSegmentsForWsl under the distro home .lightcode/attachments directory, so in a WSL Command Code thread a browser pick is staged/submitted as @/home/.../.lightcode/attachments/..., outside the worktree that the sandboxed CLI can read. This makes the new picker/attachment flow fail specifically for Command Code on WSL projects.
Useful? React with 👍 / 👎.
| } | ||
| prepared = true; | ||
| } | ||
| const dest = join(attachmentsDir, basename(segment.path)); |
There was a problem hiding this comment.
When two out-of-workspace segments share the same basename, both are copied to the same destination and the later copy overwrites the earlier one; the rewritten prompt then points both attachments at the same file. This can happen with repeated browser screenshots or files picked from different directories that have the same name, causing the agent to see the wrong attachment content. Use a per-segment unique filename or subdirectory instead of only basename(segment.path).
Useful? React with 👍 / 👎.
1 participant
Tickets: none
cliPickerTarget, and persist the setting through shared settings/defaults.