Suppress Command Code background updater during detection and spawns#183
Conversation
…awns - Add DetectionSpec.probeEnv and forward it through DetectProbeCtx - Set COMMANDCODE_SKIP_UPDATES on version probes, PTY launch, one-shots, and login
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52b1a9f419
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // `runTerminalLogin` forwards `env` into the login command; suppress the | ||
| // CLI's background self-updater so `command-code login` doesn't spawn a | ||
| // detached `npm i` terminal alongside the login overlay. | ||
| env: COMMANDCODE_SKIP_UPDATES_ENV, |
There was a problem hiding this comment.
When Command Code advertises this terminal-auth env, the native Windows Login/Re-login flow forwards it to runAgentLoginCommand, which renders env vars as a POSIX prefix (KEY='value' command) before writing the script to the login overlay; native Windows shells are started as pwsh/PowerShell/cmd in threadSessionManager, so the command becomes COMMANDCODE_SKIP_UPDATES='1' command-code login and fails before command-code login runs. This only affects native Windows terminal login for Command Code; WSL/POSIX prefixes are valid.
Useful? React with 👍 / 👎.
1 participant
--versionand related detection pathsprobeEnvsupport to agent detection so version probes and capability/auth probes can forward provider-specific environment overridesCOMMANDCODE_SKIP_UPDATES=1on Command Code version probes, PTY launches, terminal login, and one-shot utility runs while leaving explicitcommand-code updateunchanged