Skip to content

Apply aside divider border only when docked panel is open #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SDSLeon wants to merge 1 commit into from
Closed

Apply aside divider border only when docked panel is open #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/renderer/views/MainView/parts/AppShell/parts/AsideSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,21 @@ export function AsideSlot(props: {
minWidth: targetWidth,
};
} else {
// A docked panel collapses its width/height to 0 when closed, but a
// `border-t`/`border-l` on a border-box element still reserves a 1px edge even
// at size 0. That leaves a 1px strip between `main` and the window edge; with
// the translucent shell (native material) the shell behind it is transparent,
// so the strip reveals the backdrop as a stray hairline along the content's
// bottom/right. Only apply the divider border while the panel is open so a
// closed panel occupies no space and `main` reaches the edge.
const borderClass = isOpen
? isHorizontal
? "border-t border-[color:var(--border)]"
: "border-l border-[color:var(--border)]"
: "";
asideClassName = `relative overflow-hidden bg-[var(--content-background)] ${
isHorizontal
? "min-w-0 border-t border-[color:var(--border)]"
: "min-h-0 border-l border-[color:var(--border)]"
}`;
isHorizontal ? "min-w-0" : "min-h-0"
} ${borderClass}`;
asideStyle = {
...(isHorizontal
? { height: dockedDisplayHeight, minHeight: dockedDisplayHeight }
Expand Down