Add multi-provider Claude presets and preserve external model IDs#199
Conversation
- Replace GLM-only preset with z.ai, DeepSeek, and MiniMax presets and dropdown UI - Skip context-suffix rewriting for external-provider model ids (e.g. glm-5.2[1m]) - Add removeAgentStatus and call it when deleting a Claude profile
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bb8570555
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| setEnvRows((rows) => applyPresetEnvRows(preset.envRows, rows, nextRowId)); | ||
| setSelectedEfforts(nextEfforts); | ||
| setModelRows(nextModelRows); | ||
| setAgentInstance({ ...props.instance, config }); |
There was a problem hiding this comment.
Persist preset env with the model config
When a user applies a provider preset and then navigates away before pressing Save, this immediately writes the preset's models/efforts to shared settings, but the env rows added above remain only in local component state because the environment is written only by save() via setClaudeProfileEnvironment. That leaves the saved profile advertising external model IDs while missing required ANTHROPIC_BASE_URL/token/compact-window env, so launching the profile can fail or route to the wrong provider. Either keep all preset changes local until Save or persist the env portion together with this config update.
Useful? React with 👍 / 👎.
glm-5.2[1m]) when launching Claude so provider-specific suffixes are not stripped by context-size handling