fix: scope background-workflow liveness to the current session#226
Merged
Conversation
Prevent replayed workflow rows from showing a live spinner when their detached runtime process is gone (prior session or after a restart). - Add observedLive flag on runtime items, set only for live-streamed item.started events and never persisted/hydrated from the DB - Replace isLiveWorkflowRunStatus with isWorkflowRunLive, which also rejects stale `running` manifests left by a crashed runtime - Gate chat row and tile spinners on session-owned liveness - Tie manifest poller backstop to WORKFLOW_STALE_PROGRESS_MS - Add tests for isWorkflowRunLive and observedLive flagging
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
observedLiveflag on runtime chat items, set only for items that arrive via the live event stream and absent on DB-hydrated rows, so the chat row and active sub-agent tile can tell session-owned workflows apart from replayed ones.isLiveWorkflowRunStatuswithisWorkflowRunLive, which also rejects stalerunningmanifests left pinned on disk by a crashed runtime, using the run's most recent activity timestamp against a sharedWORKFLOW_STALE_PROGRESS_MSthreshold.observedLiveflagging, stale-manifest expiry, andisWorkflowRunLivebehavior.