Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bernalde
left a comment
There was a problem hiding this comment.
I reviewed the current PR head locally and ran:
/home/bernalde/repos/QuIP/.venv/bin/python -m unittest discover -s tests
~/.local/bin/uv run --group docs python -m unittest discover -s tests
QUIP_NOTEBOOK_TIMEOUT=3600 /home/bernalde/repos/QuIP/.venv/bin/python ./scripts/verify_notebooks.py notebooks_py/3-GAMA_python.ipynb notebooks_jl/3-GAMA.ipynb
make verify-julia-colab-smokes COLAB_JULIA_SMOKE_NOTEBOOKS=3-GAMA
The Python and docs unit suites passed, and the Julia Colab smoke passed. Direct execution of notebooks_py/3-GAMA_python.ipynb fails on the current head with ModuleNotFoundError: No module named 'Py4ti2int32', so I found two changes that should be made before merge and recorded them inline below.
|
Follow-up on review #4094429003: both inline findings are fixed in 4cd43c2. The Python Notebook 3 environment note now documents the local I re-ran: The three Python test runs passed. The Julia smoke finished successfully, although it still emits the existing The remaining conversation comment on this PR is the ReviewNB bot message, which is informational only and did not require a code change. |
Closes #7.
Summary
This PR aligns the Python and Julia Notebook 3 materials at the student-facing level without moving logic out of the notebooks.
What Changed
Validation
/home/bernalde/repos/QuIP/.venv/bin/python -m unittest tests.test_notebook3_pair_sync/home/bernalde/repos/QuIP/.venv/bin/python -m unittest discover -s tests~/.local/bin/uv run --group docs python -m unittest discover -s tests