Skip to content

feat: do not lock full prompt rooms - last write wins is okay #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunal0137 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat: do not lock full prompt rooms - last write wins is okay #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c77a53a
feat: do not lock full prompt rooms - last write wins is okay
kunal0137 Aug 5, 2026
9951040
Merge branch 'dev' into fix-openai-responses-locking
kunal0137 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/prerna/semoss/web/services/local/AnthropicEndpoints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,10 @@ public Response createMessage(@Context HttpServletRequest request, @Context Http

List<Map<String, Object>> messagesList = (List<Map<String, Object>>) messages;

room = RoomUtils.createRoomIfNotExists(roomId, insight, engine, null);
boolean appendFullPrompt = Boolean
.parseBoolean(String.valueOf(dataMap.remove(AbstractModelEngine.APPEND_FULL_PROMPT)));
room = appendFullPrompt ? RoomUtils.createRoomIfNotExists(roomId, insight, engine, null)
: RoomUtils.createRoomForStatelessAsk(roomId, insight, engine, null);

Object tools = dataMap.remove("tools");

Expand All @@ -277,7 +280,7 @@ public Response createMessage(@Context HttpServletRequest request, @Context Http

List<Map<String, Object>> openAIMessages = (List<Map<String, Object>>) openAIFormat.get("messages");
dataMap.put(AbstractModelEngine.FULL_PROMPT, openAIMessages);
dataMap.put("append_full_prompt", true);
dataMap.put(AbstractModelEngine.APPEND_FULL_PROMPT, appendFullPrompt);
classLogger.info("Anthropic-normalized-prompt::{}::messages={} chars={}", JOB_ID, openAIMessages.size(),
GSON.toJson(openAIMessages).length());

Expand All @@ -296,6 +299,7 @@ public Response createMessage(@Context HttpServletRequest request, @Context Http

List<Map<String, Object>> openAIMessages = (List<Map<String, Object>>) openAIFormat.get("messages");
dataMap.put(AbstractModelEngine.FULL_PROMPT, openAIMessages);
dataMap.put(AbstractModelEngine.APPEND_FULL_PROMPT, appendFullPrompt);
Gson gson = new GsonBuilder().setPrettyPrinting().create();
String openAIJson = gson.toJson(openAIMessages);
classLogger.info("Anthropic-normalized-prompt::{}::messages={} chars={}", JOB_ID, openAIMessages.size(),
Expand Down
14 changes: 9 additions & 5 deletions src/prerna/semoss/web/services/local/OpenAIEndpoints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,11 +216,11 @@ public Response runModelChatCompletion(@Context HttpServletRequest request) {
if (roomId == null) {
roomId = (String) request.getAttribute("roomId");
}
// room name gets updated during parsing of full prompt
room = RoomUtils.createRoomIfNotExists(roomId, insight, engine, null);
// this is if you are passing full prompt but want us to maintain the history
boolean appendFullPrompt = Boolean
.parseBoolean(WebUtility.inputSanitizer((String) dataMap.remove("append_full_prompt")) + "");
.parseBoolean(String.valueOf(dataMap.remove(AbstractModelEngine.APPEND_FULL_PROMPT)));
// room name gets updated during parsing of full prompt
room = appendFullPrompt ? RoomUtils.createRoomIfNotExists(roomId, insight, engine, null)
: RoomUtils.createRoomForStatelessAsk(roomId, insight, engine, null);

ModelPixelExecutor.initializeThreadStore(insight, SESSION_ID, JOB_ID);

Expand Down Expand Up @@ -569,11 +569,15 @@ public Response runResponses(@Context HttpServletRequest request) {
if (roomId == null) {
roomId = resolveRoomIdFromCodexHeaders(request);
}
room = RoomUtils.createRoomIfNotExists(roomId, insight, engine, null);
boolean appendFullPrompt = Boolean
.parseBoolean(String.valueOf(dataMap.remove(AbstractModelEngine.APPEND_FULL_PROMPT)));
room = appendFullPrompt ? RoomUtils.createRoomIfNotExists(roomId, insight, engine, null)
: RoomUtils.createRoomForStatelessAsk(roomId, insight, engine, null);

ModelPixelExecutor.initializeThreadStore(insight, SESSION_ID, JOB_ID);

dataMap.put(AbstractModelEngine.FULL_PROMPT, messages);
dataMap.put(AbstractModelEngine.APPEND_FULL_PROMPT, appendFullPrompt);

if (!isStreamingRequest) {
try {
Expand Down
Loading