Skip to content

feat: notification system #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kunal0137 wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

feat: notification system #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad853a7
fix(notification): security - scope notification mutations to recipient
kunal0137 Jul 9, 2026
c7e384f
feat: creating notification tables
kunal0137 Jul 9, 2026
4a080fe
feat: allow multiple display types for notifications
kunal0137 Jul 9, 2026
f9cd2b1
feat: enable app based notifications
kunal0137 Jul 9, 2026
adb1a36
fix: consolidating changes for now
kunal0137 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions src/prerna/auth/utils/SecurityEngineUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,9 +665,10 @@ public static void approveEngineUserAccessRequests(User user, String engineId, L
if (Utility.isNotificationDatabaseEnabled()) {
String engineType = String.valueOf(getEngineType(engineId)).toLowerCase();
for (int i = 0; i < requests.size(); i++) {
NotificationDbUtils.createNotification(user, requests.get(i).get("userid"),
requests.get(i).get("type"), engineId, NotificationConstants.Type.REQUEST_APPROVAL,
engineType, NotificationConstants.Priority.MEDIUM, null, requests.get(i).get("permission"));
NotificationDbUtils.createNotification(user, requests.get(i).get("userid"),
requests.get(i).get("type"), engineId, NotificationConstants.Type.REQUEST_APPROVAL,
engineType, NotificationConstants.Priority.MEDIUM, null, requests.get(i).get("permission"),
NotificationConstants.DisplaySurface.BELL);
// Adding email notification
EmailUtility.sendAccessRequestApprovalEmailNotification(user, requests.get(i).get("userid"),
engineId, requests.get(i).get("permission"), EmailUtility.RESOURCE_TYPE.ENGINE);
Expand Down Expand Up @@ -738,10 +739,11 @@ public static void denyEngineUserAccessRequests(User user, String engineId, List
List<Map<String, Object>> deniedUserDetails = getUserDetailsFromEngineAccessRequest(requestId);
String permission = AccessPermissionEnum
.getPermissionValueById((Integer) deniedUserDetails.get(i).get("permission"));
NotificationDbUtils.createNotification(user, (String) deniedUserDetails.get(i).get("userId"),
(String) deniedUserDetails.get(i).get("type"), engineId,
NotificationConstants.Type.REQUEST_DENIAL, engineType,
NotificationConstants.Priority.MEDIUM, null, permission);
NotificationDbUtils.createNotification(user, (String) deniedUserDetails.get(i).get("userId"),
(String) deniedUserDetails.get(i).get("type"), engineId,
NotificationConstants.Type.REQUEST_DENIAL, engineType,
NotificationConstants.Priority.MEDIUM, null, permission,
NotificationConstants.DisplaySurface.BELL);
}
}

Expand Down Expand Up @@ -1154,10 +1156,10 @@ public static void addEngineUserPermissions(User user, String engineId, List<Map
if (Utility.isNotificationDatabaseEnabled()) {
String engineType = String.valueOf(getEngineType(engineId)).toLowerCase();
for (int i = 0; i < permission.size(); i++) {
NotificationDbUtils.createNotification(user, (String) permission.get(i).get("userid"),
(String) permission.get(i).get("type"), engineId, NotificationConstants.Type.USER_ADDITION,
engineType, NotificationConstants.Priority.MEDIUM, null,
(String) permission.get(i).get("permission"));
NotificationDbUtils.createNotification(user, (String) permission.get(i).get("userid"),
(String) permission.get(i).get("type"), engineId, NotificationConstants.Type.USER_ADDITION,
engineType, NotificationConstants.Priority.MEDIUM, null,
(String) permission.get(i).get("permission"), NotificationConstants.DisplaySurface.BELL);
}
}

Expand Down Expand Up @@ -1271,9 +1273,9 @@ public static void editEngineUserPermission(User user, String existingUserId, St
if (Utility.isNotificationDatabaseEnabled()) {
String engineType = String.valueOf(getEngineType(engineId)).toLowerCase();
String existingPermission = AccessPermissionEnum.getPermissionValueById(existingUserPermission);
NotificationDbUtils.createNotification(user, existingUserId, existingUserType, engineId,
NotificationConstants.Type.PERMISSION_CHANGE, engineType, NotificationConstants.Priority.MEDIUM,
existingPermission, newPermission);
NotificationDbUtils.createNotification(user, existingUserId, existingUserType, engineId,
NotificationConstants.Type.PERMISSION_CHANGE, engineType, NotificationConstants.Priority.MEDIUM,
existingPermission, newPermission, NotificationConstants.DisplaySurface.BELL);
}
} catch (Exception e) {
classLogger.error("Failed to update engine user permission", e);
Expand Down Expand Up @@ -1400,10 +1402,10 @@ public static void editEngineUserPermissions(User user, String engineId, List<Ma

// Adding Notification
if (Utility.isNotificationDatabaseEnabled()) {
NotificationDbUtils.createNotification(user, newUserId, newUserType, engineId,
NotificationConstants.Type.PERMISSION_CHANGE, engineType,
NotificationConstants.Priority.MEDIUM, existingPermission,
(String) thisPermissionMap.get("permission"));
NotificationDbUtils.createNotification(user, newUserId, newUserType, engineId,
NotificationConstants.Type.PERMISSION_CHANGE, engineType,
NotificationConstants.Priority.MEDIUM, existingPermission,
(String) thisPermissionMap.get("permission"), NotificationConstants.DisplaySurface.BELL);
}
}
ps.executeBatch();
Expand Down
42 changes: 22 additions & 20 deletions src/prerna/auth/utils/SecurityProjectUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,10 +1544,11 @@ public static void editProjectUserPermission(User user, String existingUserId, S
// Adding Notification
// Check notificationDb (conditional)
if (Utility.isNotificationDatabaseEnabled()) {
String existingPermission = AccessPermissionEnum.getPermissionValueById(existingUserPermission);
NotificationDbUtils.createNotification(user, existingUserId, existingUserType, projectId,
NotificationConstants.Type.PERMISSION_CHANGE, NotificationConstants.APP_CATALOG,
NotificationConstants.Priority.MEDIUM, existingPermission, newPermission);
String existingPermission = AccessPermissionEnum.getPermissionValueById(existingUserPermission);
NotificationDbUtils.createNotification(user, existingUserId, existingUserType, projectId,
NotificationConstants.Type.PERMISSION_CHANGE, NotificationConstants.APP_CATALOG,
NotificationConstants.Priority.MEDIUM, existingPermission, newPermission,
NotificationConstants.DisplaySurface.BELL);
}
} catch (Exception e) {
classLogger.error("Failed to update project user permission", e);
Expand Down Expand Up @@ -1644,10 +1645,10 @@ public static void editProjectUserPermissions(User user, String projectId, List<

// Adding Notification
if (Utility.isNotificationDatabaseEnabled()) {
NotificationDbUtils.createNotification(user, newUserId, newUserType, projectId,
NotificationConstants.Type.PERMISSION_CHANGE, NotificationConstants.APP_CATALOG,
NotificationConstants.Priority.MEDIUM, existingPermission,
requests.get(i).get("permission"));
NotificationDbUtils.createNotification(user, newUserId, newUserType, projectId,
NotificationConstants.Type.PERMISSION_CHANGE, NotificationConstants.APP_CATALOG,
NotificationConstants.Priority.MEDIUM, existingPermission,
requests.get(i).get("permission"), NotificationConstants.DisplaySurface.BELL);
}
}
ps.executeBatch();
Expand Down Expand Up @@ -4665,10 +4666,10 @@ public static void approveProjectUserAccessRequests(User user, String projectId,
// Adding Notification
if (Utility.isNotificationDatabaseEnabled()) {
for (int i = 0; i < requests.size(); i++) {
NotificationDbUtils.createNotification(user, requests.get(i).get("userid"),
requests.get(i).get("type"), projectId, NotificationConstants.Type.REQUEST_APPROVAL,
NotificationConstants.APP_CATALOG, NotificationConstants.Priority.MEDIUM, null,
requests.get(i).get("permission"));
NotificationDbUtils.createNotification(user, requests.get(i).get("userid"),
requests.get(i).get("type"), projectId, NotificationConstants.Type.REQUEST_APPROVAL,
NotificationConstants.APP_CATALOG, NotificationConstants.Priority.MEDIUM, null,
requests.get(i).get("permission"), NotificationConstants.DisplaySurface.BELL);
// Adding email notification
EmailUtility.sendAccessRequestApprovalEmailNotification(user, requests.get(i).get("userid"),
projectId, requests.get(i).get("permission"), EmailUtility.RESOURCE_TYPE.PROJECT);
Expand Down Expand Up @@ -4738,10 +4739,11 @@ public static void denyProjectUserAccessRequests(User user, String projectId, Li
List<Map<String, Object>> deniedUserDetails = getUserDetailsFromProjectAccessRequest(requestId);
String permission = AccessPermissionEnum
.getPermissionValueById((Integer) deniedUserDetails.get(i).get("permission"));
NotificationDbUtils.createNotification(user, (String) deniedUserDetails.get(i).get("userId"),
(String) deniedUserDetails.get(i).get("type"), projectId,
NotificationConstants.Type.REQUEST_DENIAL, NotificationConstants.APP_CATALOG,
NotificationConstants.Priority.MEDIUM, null, permission);
NotificationDbUtils.createNotification(user, (String) deniedUserDetails.get(i).get("userId"),
(String) deniedUserDetails.get(i).get("type"), projectId,
NotificationConstants.Type.REQUEST_DENIAL, NotificationConstants.APP_CATALOG,
NotificationConstants.Priority.MEDIUM, null, permission,
NotificationConstants.DisplaySurface.BELL);
}
}

Expand Down Expand Up @@ -4825,10 +4827,10 @@ public static void addProjectUserPermissions(User user, String projectId, List<M
// Adding Notification
if (Utility.isNotificationDatabaseEnabled()) {
for (int i = 0; i < permission.size(); i++) {
NotificationDbUtils.createNotification(user, permission.get(i).get("userid"),
permission.get(i).get("type"), projectId, NotificationConstants.Type.USER_ADDITION,
NotificationConstants.APP_CATALOG, NotificationConstants.Priority.MEDIUM, null,
permission.get(i).get("permission"));
NotificationDbUtils.createNotification(user, permission.get(i).get("userid"),
permission.get(i).get("type"), projectId, NotificationConstants.Type.USER_ADDITION,
NotificationConstants.APP_CATALOG, NotificationConstants.Priority.MEDIUM, null,
permission.get(i).get("permission"), NotificationConstants.DisplaySurface.BELL);
}
}

Expand Down
Loading
Loading