perf(faiss): batch Vector CSV embeddings - #2759
Open
greglum wants to merge 1 commit into
Open
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This was referenced Jul 16, 2026
greglum
marked this pull request as ready for review
July 17, 2026 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A Vector CSV can contain many Sources. The prior implementation invoked the embedding engine once for every Source, which adds avoidable model overhead during grouped corpus ingestion. This keeps the existing artifact and removal contracts while changing only the embedding unit of work.
Behavior change
The previous code popped
keywordSearchfrom the caller's parameter dict inside the per-Source loop, so keyword extraction only ever applied to the first Source of the first document and the caller's dict was mutated. This PR reads the flag once per document from a copy, so extraction now runs for every configured Source and the caller's dict is left intact. This is an intentional fix, covered bytest_keyword_search_remains_a_per_source_fallback.Verification
The older FAISS integration tests require a configured local model or a running Tomcat instance and fail during their environment setup before exercising this path.
Related work