Search Bar Enhancement: add message content search backend - #2764
Search Bar Enhancement: add message content search backend#2764Kaveh-Vakili wants to merge 35 commits into
Conversation
- SearchRoomMessagesReactor: add limit, offset, includeMessageText keys; remove projectId fallback so omitting it searches across all projects; wire 6-arg searchMessages; update reactor description - ModelInferenceLogsUtils: add 6-arg searchMessages overload with pagination and optional message text; backward-compat 3-arg delegate; add room_name/date_created selectors; LOWER() wrap for case-insensitive LIKE; % wildcards on keyword; null-guard on projectId
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Overall: Validated the reactor live against a running instance — content search, all-projects default, room_name/date_created, optional message text, case-insensitivity, and pagination all work. A few things in the new code to address before merge. Should fix
Minor
|
…d pagination tiebreaker, fix Javadoc
…includeMessageText
…without-LIMIT guard; fix description
|
I'm seeing some funky behavior with this reactor, it's returning "rooms" that shouldn't be exposed to the user, like summarization and prompt optimization "rooms" for example |
|
Also, it appears not to be returning valid rooms when it ought to, like when I'm actually searching for a real message it doesn't come back |
|
We'd have to revert ROOM_ID != INSIGHT_ID filter since Thomas confirmed it's also filtering out valid rooms. To properly fix this we'd need a schema change. Either an IS_SYSTEM flag on internal rooms or an IS_USER_CREATED flag on user rooms. |
|
Confirmed locally: pagination is applied to matching messages, but the UI displays matching rooms. additionally infinite or additonal scroll doesnt work after. |
searchMessages applied limit/offset at message grain, so a single room with many matching messages could fill an entire page and hide other rooms that only matched once. Reduce to one row per room (most recent match) before limit/offset are applied, so pagination is over matching rooms rather than raw message rows.
…moss into Search-Bar-Enhancement
|
we should have SearchRoomMessages return room date_created instead of message date_created (right now it's pulling MESSAGE__DATE_CREATED while GetPlaygroundRooms pulls ROOM__DATE_CREATED under the same field name, so the same room can show two different dates depending on which endpoint returns it) |
…undRooms date field
Goes with SEMOSS/semoss-ui#3445
Description
Formulated a more robust solution for the playground search bar that is able to search for content within different rooms.
Changes Made
How to Test
Notes