Merge dragdnddrop tests - #1035
Open
3ashour wants to merge 74 commits into
Open
Conversation
…sts #1031 . -Converted CodeAppFiles.Feature Scenarios to pure JUnit -Added proper @beforeeach setup and @AfterEach cleanup . -Reused existing Utilities .
…sTests #1031 -Converted CodeAppSettings.Feature scenarios to pure Junit . -Added proper @beforeeach setup and @AfterEach cleanup . -Reused existing Utilities .
test : convert drag and drop template tests to Junit .
This reverts commit 9f52a00.
…sted rules -Add test cases for " unfiltered Data " scenario to verify all columns and row count . - Add test cases for "Filter Data" . - Add test cases for nested rule filter with And Operator . - Verify frame ID validation after running notebook cells . - Add helper method openNotebookAndStartDataFilter() to reduce code duplication - Update clean up test app and catalog after each test
- Add test cases for validate Import Database Query . - Add test cases for Import Data Edit Button and Import Data Form - Update clean up test app and catalog after each test
- Add test cases for test Creation And Duplication Of New Notebook - Add test cases for "Filter Data" . - Add test cases for test Deletion Of New Notebook . - Add test cases for test Search Functionality Of New Notebook .
- Add test cases for Uppercase Function In Transformation. - Update clean up test app and catalog after each test
- Add test cases for test Python Output In Notebook . - Add test cases for test Pixel Output In Notebook - Update clean up test app and catalog after each test
- Add Verify Column Values Test Cases . -Add Verify Time stamp Function Test . - Update clean up test app and catalog after each test
-Replace NotebookPageUtils.java with fixed version . -Changes two methods only .
…m/SEMOSS/e2e into feature/convert-DragAndDrop-junit
- add waits to getToastMessage() method . - add isChecked() to isPortalToggleInExpectedState() method .
ericgonzal8
requested changes
Aug 6, 2026
ericgonzal8
left a comment
ericgonzal8
left a comment
Contributor
There was a problem hiding this comment.
Please review the comments and address the concerns, thanks
ericgonzal8
requested changes
Aug 10, 2026
| verifyWelcomePage(page); | ||
| DragAndDropBlocksPageUtils.clickOnBlocksOption(page); | ||
|
|
||
| String databaseId = DatabaseTestUtils.uploadDatabaseZip( |
Contributor
There was a problem hiding this comment.
Add the resource locks to all the tests in this class since this resource is being uploaded in the BeforeEach
|
|
||
| @AfterEach | ||
| void tearDown(@PWPage Page page) { | ||
| CommonUtils.navigateAndDeleteApp(page, appName); |
Contributor
There was a problem hiding this comment.
Also need to delete the uploaded resource here. The uploading util will check if the resource exists and try to delete it before uploading but the tests need to be able to run in clean environments each time so as to ensure consistent outcomes regardless of order of execution.
| private String appName; | ||
|
|
||
| @BeforeEach | ||
| @ResourceUploadLock(TestResources.TEST_DATABASE_ZIP) |
Contributor
There was a problem hiding this comment.
These resource lock tags need to be applied to the test methods rather than these life-cycle methods. Also can cause bottle-necks when locking resources for tests that don't need it. Please move to the applicable tests
| } | ||
|
|
||
| @AfterEach | ||
| void tearDown(@PWPage Page page) { |
Contributor
There was a problem hiding this comment.
ensure you are also deleting the uploaded resources after the test
|
|
||
|
|
||
| @Test | ||
| public void validateAscendingAndDescendingFilter_test(@PWPage Page page) { |
Contributor
There was a problem hiding this comment.
These app resources also need to be cleaned up when the test finishes.
|
|
||
|
|
||
| @Test | ||
| public void validateDateModifiedFilter_test(@PWPage Page page) { |
Contributor
There was a problem hiding this comment.
These app resources also need to be cleaned up when the test finishes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
How to Test
Notes