fix: fixed mobile scrolling issue for elsa-beta - #3557
Open
ekim1707 wants to merge 2 commits into
Open
Conversation
Contributor
|
Happy to show this works and fixes the issue described. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues elsa-beta had scrolling in mobile. It seems the iframes were getting jumbled together such that the active iframe was not accessible to the finger touch.
Changes Made
Added visibility: isActive ? "visible" : "hidden" to the inactive iframe's style, and removed the now-redundant opacity: isActive ? 1 : 0
How to Test
Notes
@kzsb03 there won't be any way for you to test without an FDA phone, however @ckelly17 and I worked together to test on his phone, and it worked.