Skip to content

metadata oops updates#190

Merged
jnspitale merged 7 commits intomainfrom
jns-metadata-updates
Feb 19, 2026
Merged

metadata oops updates#190
jnspitale merged 7 commits intomainfrom
jns-metadata-updates

Conversation

@jnspitale
Copy link
Collaborator

@jnspitale jnspitale commented Dec 10, 2025

Summary by CodeRabbit

  • New Features

    • Improved limb clock-angle handling to support altitude-based masking with optional scaling.
  • Bug Fixes

    • Corrected z-range masking so the upper bound is scaled properly when scaling is enabled.
    • Hardened telemetry metadata handling by supplying sensible defaults when fields are missing.
  • Improvements

    • Switched to a more reliable label parsing approach, streamlined image loading, refined field-of-view entries, and updated frame initialization.

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Walkthrough

Scaled-mode limb backplane now scales zmax (not zmin), uses a local clock_angle when registering the clock-angle backplane, and removed the unconditional fallback that forced limb intercept filling. Galileo SSI init now uses pdsparser for labels, simplifies VICAR loading, defaults TELEMETRY_FORMAT_ID to 'NONE', adds a NONE FOV, and replaces a SpiceFrame with SpiceType1Frame("GLL_SCAN_PLATFORM", -77, 40).

Changes

Cohort / File(s) Summary
Limb backplane adjustments
oops/backplane/limb.py
In scaled mode, stop scaling zmin; scale zmax when present. Introduced a local clock_angle and use it for backplane registration. Removed the previous unconditional call to _fill_limb_intercepts fallback logic.
Galileo SSI init & metadata
oops/hosts/galileo/ssi/__init__.py
Use pdsparser.Pds3Label(filespec).as_dict() for PDS3 labels; load VICAR via vicar.VicarImage.from_file(filespec); default TELEMETRY_FORMAT_ID to 'NONE'; add NONE entry to SSI.fovs mapping; replace SpiceFrame("GLL_SCAN_PLATFORM") with SpiceType1Frame("GLL_SCAN_PLATFORM", -77, 40) and add explanatory comments.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'metadata oops updates' is vague and generic, using non-descriptive terms that don't convey meaningful information about the actual changes made. Use a more specific title that reflects the primary change, such as 'Fix limb_altitude scaling and update Galileo SSI metadata handling' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as outdated.

@jnspitale jnspitale changed the title safety push metadata oops updates Dec 11, 2025
@rfrenchseti rfrenchseti marked this pull request as ready for review December 11, 2025 23:44
markshowalter

This comment was marked as resolved.

@rfrenchseti
Copy link
Collaborator

@jnspitale are we waiting on your to finish changes to this PR?

coderabbitai[bot]

This comment was marked as resolved.

@jnspitale
Copy link
Collaborator Author

jnspitale commented Feb 9, 2026

@jnspitale are we waiting on your to finish changes to this PR?

It should be ready. I requested a re-review from Mark.

Copy link
Collaborator

@markshowalter markshowalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@jnspitale jnspitale merged commit 1be86db into main Feb 19, 2026
14 checks passed
@jnspitale jnspitale deleted the jns-metadata-updates branch February 19, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants