Skip to content

feature: add video player component to lesson pages - #121

Open
gabrielkimbio2-lgtm wants to merge 7 commits into
SJA-Pathway:devfrom
gabrielkimbio2-lgtm:feature/video-lessons
Open

feature: add video player component to lesson pages#121
gabrielkimbio2-lgtm wants to merge 7 commits into
SJA-Pathway:devfrom
gabrielkimbio2-lgtm:feature/video-lessons

Conversation

@gabrielkimbio2-lgtm

Copy link
Copy Markdown
Collaborator

Pull Request

What did you change?

  • Added a videoId field to the Topic type.
  • Implemented a responsive video player in the lesson page.
  • Added a video-wrapper class to the CSS for professional styling.

What issue does this fix?
Write the issue number here: #114

Checklist:

  • I checked the video player on the frontend.
  • I used a clean CSS class instead of inline styles.
  • This is a separate focused task .

@abdullah-builds-dev

Copy link
Copy Markdown
Collaborator

Video player setup and CSS wrapper look fine, and the videoId field in the type is correct. But the iframe is hard‑coded to a YouTube link instead of using topic.videoId, so the new field isn’t applied. The videoId in frontend.json also doesn’t look like a valid YouTube ID. Please fix these issues

@najibullahjafari najibullahjafari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice done but consider to resolve the Cloudflare deployment issues.

@najibullahjafari

Copy link
Copy Markdown
Collaborator

@gabrielkimbio2-lgtm Please resolve the conflicts

@gabrielkimbio2-lgtm

Copy link
Copy Markdown
Collaborator Author

@najibullahjafari The Cloudflare deployment is failing because the GitHub
Action needs CLOUDFLARE_API_TOKEN and CLOUDFLARE_ACCOUNT_ID secrets
configured in the repository settings.

I've tested my changes locally with Wrangler v4.81.0 and the deployment works.

Could you please add the required Cloudflare secrets to the repository,
or advise on the correct configuration for the preview deployment?

Cloudflare Deployment Test

I've successfully deployed my changes manually using Wrangler:

Preview URL: https://de465213.webpath.pages.dev
Build successful: No errors in the build process

Video player works: The dynamic YouTube player functions correctly with valid video IDs

The GitHub Action deployment failure is due to missing repository secrets (CLOUDFLARE_API_TOKEN, CLOUDFLARE_ACCOUNT_ID), not an issue with my code.

@najibullahjafari The manual deployment proves my changes work. Please add the required Cloudflare secrets to the repository or help resolve the workflow configuration.

@najibullahjafari

Copy link
Copy Markdown
Collaborator

@gabrielkimbio2-lgtm
I mean the conflicts of these two files

src/app/globals.css
src/app/paths/[pathSlug]/[topicSlug]/page.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants