feature: add video player component to lesson pages - #121
feature: add video player component to lesson pages#121gabrielkimbio2-lgtm wants to merge 7 commits into
Conversation
|
Video player setup and CSS wrapper look fine, and the videoId field in the type is correct. But the iframe is hard‑coded to a YouTube link instead of using topic.videoId, so the new field isn’t applied. The videoId in frontend.json also doesn’t look like a valid YouTube ID. Please fix these issues |
najibullahjafari
left a comment
There was a problem hiding this comment.
Nice done but consider to resolve the Cloudflare deployment issues.
…deo IDs, and clean types
|
@gabrielkimbio2-lgtm Please resolve the conflicts |
|
@najibullahjafari The Cloudflare deployment is failing because the GitHub I've tested my changes locally with Wrangler v4.81.0 and the deployment works. Could you please add the required Cloudflare secrets to the repository, Cloudflare Deployment TestI've successfully deployed my changes manually using Wrangler: Preview URL: https://de465213.webpath.pages.dev Video player works: The dynamic YouTube player functions correctly with valid video IDs The GitHub Action deployment failure is due to missing repository secrets ( @najibullahjafari The manual deployment proves my changes work. Please add the required Cloudflare secrets to the repository or help resolve the workflow configuration. |
|
@gabrielkimbio2-lgtm |
Pull Request
What did you change?
videoIdfield to the Topic type.video-wrapperclass to the CSS for professional styling.What issue does this fix?
Write the issue number here: #114
Checklist: