Feat/greedy minimessage arg#392
Conversation
- introduce greedy parameter to MiniMessageArgument constructor - update miniMessageArgument function to accept greedy argument - change default command exception message prefix to Colors.ERROR_PREFIX - increment version to 3.32.0 in gradle.properties
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5329982c48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| public class dev/slne/surf/api/paper/command/args/MiniMessageArgument : dev/jorel/commandapi/arguments/CustomArgument { | ||
| public fun <init> (Ljava/lang/String;)V | ||
| public synthetic fun <init> (Ljava/lang/String;)V |
There was a problem hiding this comment.
For Java plugins that recompile against 3.32 and still instantiate new MiniMessageArgument("message"), this changes the old constructor to a synthetic member; javac ignores synthetic members during source resolution, so those callers no longer compile even though greedy defaults to false. Please keep a non-synthetic one-argument overload when adding the new boolean parameter.
Useful? React with 👍 / 👎.
1 participant
No description provided.