Dev version/26.2#41
Closed
TheBjoRedCraft wants to merge 16 commits into
Closed
Conversation
Add external event configuration options
Add condition to check external event configuration before teleporting player.
Added external event handling for NPC interactions, allowing teleportation to a specified location if enabled.
Removed 'surf-hologram-paper' from server dependencies.
Adjusted whitespace in text output for better formatting.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the lobby plugin for the “26.2” dev version by adjusting navigation/NPC UX and adding configuration to optionally redirect the default event interaction to an externally configured teleport target.
Changes:
- Add config-driven “external event” teleport behavior (optionally replacing the default event destination) in the navigator inventory and event NPC interactions.
- Update lobby-facing UI text/labels (e.g., lobby selector title, rules URL, survival branding to “CastSMP”) and refresh NPC skins/scaling.
- Bump project version and switch build dependencies to Nexo snapshot/dev coordinates, removing an unused soft dependency entry.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/dev/slne/surf/lobby/inventory/impl/NavigatorInventory.kt | Adds external-event replacement teleport path; updates rules URL and survival branding/lore. |
| src/main/kotlin/dev/slne/surf/lobby/hook/trophy/TrophyHook.kt | Switches trophy API access to SurfTrophyApi. |
| src/main/kotlin/dev/slne/surf/lobby/hook/npc/SurfNpcSkins.kt | Updates skin payloads and enables all NpcSkinPart parts when constructing NpcSkin. |
| src/main/kotlin/dev/slne/surf/lobby/hook/npc/SurfNpcHook.kt | Updates NPC display names/teleport logic; adds scaling; adds external-event replacement teleport path. |
| src/main/kotlin/dev/slne/surf/lobby/config/LobbyConfig.kt | Introduces external-event config fields and changes default world resolution logic. |
| gradle.properties | Bumps plugin version to 3.1.9. |
| build.gradle.kts | Switches to Nexo snapshots + dev version, and removes surf-hologram-paper soft dependency registration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.