feat: rename LobbySettingsMenu to OtherSettingsMenu and add nametag v…

[TheBjoRedCraft]

…isibility setting

[Copilot]

Pull request overview

This PR renames the “Lobby” settings submenu to a more general “Other/Allgemein” menu and adds a new player setting to control nametag visibility, wiring it into the Paper GUI flow.

Changes:

• Renamed LobbySettingsMenu to OtherSettingsMenu and updated registrations/navigation.
• Added a new boolean setting key SHOW_NAMETAGS and a GUI toggle item for it.
• Bumped project version from 2.2.5 to 2.2.6.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
surf-settings-paper/src/main/kotlin/dev/slne/surf/settings/paper/PaperMain.kt	Updates menu registration/imports to the renamed submenu.
surf-settings-paper/src/main/kotlin/dev/slne/surf/settings/paper/menu/sub/OtherSettingsMenu.kt	Renames the submenu, adds nametag visibility toggle, and adjusts layout/text.
surf-settings-paper/src/main/kotlin/dev/slne/surf/settings/paper/menu/SettingsMenu.kt	Routes the main settings menu entry to open OtherSettingsMenu.
surf-settings-api/src/main/kotlin/dev/slne/surf/settings/api/setting/SettingKeys.kt	Introduces SHOW_NAMETAGS SettingKey.
gradle.properties	Version bump to 2.2.6.

Comments suppressed due to low confidence (1)

surf-settings-paper/src/main/kotlin/dev/slne/surf/settings/paper/menu/sub/OtherSettingsMenu.kt:45

• OtherSettingsMenu initializes scroll/joinScroll and nametag/joinNametag by calling SurfSettingsApi.getSettingValue twice per key. Other menus (e.g., ChatSettingsMenu) fetch each setting once into a local variable and then set both the current and initial states from that value. Reusing the fetched value here reduces duplication and keeps the pattern consistent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.