Conversation
Split `ConnectionInput` into two separate types, with a new `ConnectionInputBuilder`, which omits the `source` field. A new `build` method is added instead, which returns a `ConnectionInput`, which contains a `source` field that is non-optional. This allows to not have to check for a default Redis key for the `QueryRoot.players` and `QueryRoot.maps` GraphQL nodes, because it must be provided by the caller. The types are moved into a new submodule in the utils module. The struct `EitherRedisKey` and the function `custom_source_or` are removed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the ConnectionInput structure by introducing a builder pattern that ensures the source field is always provided explicitly. The refactoring eliminates the need for default Redis key handling and improves type safety.
Changes:
- Split
ConnectionInputintoConnectionInputBuilderandConnectionInputtypes, moving them to a newconnection_inputsubmodule - Made
sourcea required parameter via the builder'sbuildmethod - Removed helper types
EitherRedisKeyandcustom_source_orfunction that handled optional source defaults
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/graphql-api/src/utils/mod.rs | Adds the new connection_input module |
| crates/graphql-api/src/utils/connection_input.rs | Defines the new ConnectionInputBuilder and ConnectionInput types with builder pattern |
| crates/graphql-api/src/tests/queryroot_players_connection.rs | Updates test calls to use ConnectionInputBuilder with explicit build(source) |
| crates/graphql-api/src/tests/queryroot_maps_connection.rs | Updates test calls to use ConnectionInputBuilder with explicit build(source) |
| crates/graphql-api/src/objects/root.rs | Updates production code to use the builder pattern, removes old types and helper functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
ConnectionInputinto two separate types, with a newConnectionInputBuilder, which omits thesourcefield. A newbuildmethod is added instead, which returns aConnectionInput, which contains asourcefield that is non-optional.This allows to not have to check for a default Redis key for the
QueryRoot.playersandQueryRoot.mapsGraphQL nodes, because it must be provided by the caller.The types are moved into a new submodule in the utils module. The struct
EitherRedisKeyand the functioncustom_source_orare removed.