Conversation
Adding IR-filters to ANDICAM and adding filters for TJO MEIA3
… into 135-redefine_filters
emirkmo
left a comment
emirkmo
left a comment
There was a problem hiding this comment.
You need to add an AndiCamIR instrument class. You can have it inherit from AndiCam, but have a different instrument header name and overwrite the get_photfilter method.
This won't work.
flows/instruments/instruments.py
Outdated
| def get_photfilter(self): | ||
| return self.image.header['CCDFLTID'] | ||
| instrument = self.image.header['INSTRUME'] | ||
| if instrument == 'ANDICAM-IR': |
There was a problem hiding this comment.
instrument is already set to be ANDICAM-CCD, so create a new AndiCamIR instrument for this. If the instrument field is AndiCamIR this class won't even detect that the image belongs to the AndiCam pipeline.
There was a problem hiding this comment.
I tried something like:
class AndiCamIR(Instrument):
andicam = AndiCam()
siteid = andicam.siteid
instrument = 'ANDICAM-CCD’
unique_headers = andicam.unique_headers
def get_obstime(self):
return andicam.get_obstime()
def get_photfilter(self):
return self.image.header['IRFLTID']
However, this does not seem to work. In the current commit, I added some spaces to a file, but it seems it does not pass the checks. Is something off with the pipeline?
2 participants
Added Andicam NIR and TJO filters