feat: adicionar serviço agendado para remover itens(supplies) abaixo de urgente e registrar logs#157
Open
luizpbello wants to merge 10 commits intoSOS-RS:developfrom
Open
feat: adicionar serviço agendado para remover itens(supplies) abaixo de urgente e registrar logs#157luizpbello wants to merge 10 commits intoSOS-RS:developfrom
luizpbello wants to merge 10 commits intoSOS-RS:developfrom
Conversation
…de urgente a cada 48h
rodrigooler
requested changes
May 20, 2024
Contributor
rodrigooler
left a comment
rodrigooler
left a comment
There was a problem hiding this comment.
Realizei uma revisão do código e identifiquei alguns pontos que podem ser aprimorados. Caso tenha alguma dúvida, sinta-se à vontade para me chamar no privado no Discord.
… abrigo não urgentes após 48 horas de inatividade. Implementada lógica de verificação de tempo decorrido com base em date-fns e utilização de transações do Prisma para garantir consistência de dados.
…ra facilitar leitura do código.
…dentro de removeShelterSupply
thiagodejesus
left a comment
thiagodejesus
left a comment
There was a problem hiding this comment.
Examinando o código encontrei uma possível melhoria.
…nte na busca com o Prisma, removendo funcções auxiliares de validação.
prisma/migrations/20240520151114_create_supplu_auto_remove_logs/migration.sql
Outdated
Show resolved
Hide resolved
thiagodejesus
approved these changes
May 21, 2024
thiagodejesus
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criei um service com o schedule module do NestJS pra verificar a cada 48h itens dos abrigos(supplies), caso eles tenham sido criados ou atualizados a mais de 48 e não estejam com a prioridade de urgente, vão ser removidos.
Foi criada uma tabela SupplyAutoRemoveLog pra registrar os logs desse serviço.