Feat/handle duplicated supplies #Issue 179#192
Open
carolrochafloro wants to merge 6 commits intoSOS-RS:developfrom
Open
Feat/handle duplicated supplies #Issue 179#192carolrochafloro wants to merge 6 commits intoSOS-RS:developfrom
carolrochafloro wants to merge 6 commits intoSOS-RS:developfrom
Conversation
…e, slugifying both existing and new data before comparrison. Called the service on Post method on supply.service.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #179
Criei services de validação para verificar a inclusão de itens duplicados em supply e suplly category.
Criei uma função slugify em utils para normalizar os nomes antes da comparação.
Não criei uma query para remover dados duplicados do DB, pois existem itens associados a eles no history e os supplies já estão sendo filtrados por um select distincs no service index()
Criei testes correspondentes às funcionalidades implementadas.