feat: Add request body validation with DTOs & Swagger docs to the routes#96
Open
ocsoares wants to merge 13 commits intoSOS-RS:developfrom
Open
feat: Add request body validation with DTOs & Swagger docs to the routes#96ocsoares wants to merge 13 commits intoSOS-RS:developfrom
ocsoares wants to merge 13 commits intoSOS-RS:developfrom
Conversation
MathiTz
reviewed
May 14, 2024
| @IsNumber() | ||
| @Min(1) | ||
| @Transform((value) => Number(value.value)) | ||
| readonly quantity?: number; |
There was a problem hiding this comment.
não deveria ser obrigatório? afinal estou criando um suprimento e estou dizendo que seu deve ser mínimo um
Author
There was a problem hiding this comment.
Eu apenas segui a lógica já implementada na aplicação, então nesse DTO a propriedade "quantity" deve ser opcional, como consta nos types
backend/src/shelter-supply/types.ts
Lines 5 to 25 in c40e724
There was a problem hiding this comment.
Perfeito! Acredito que não era para ter esse 'estado' nos types mas como já é o formato antigo, tudo em ordem camarada
MathiTz
approved these changes
May 14, 2024
d6e5d62 to
3e68056
Compare
giovanifranz
approved these changes
May 14, 2024
BrunoColpani
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essse PR adiciona a validação do corpo das requisições nas rotas, garantindo que apenas os dados solicitados pela aplicação sejam aceitos, com a tipagem correta. Foi utilizado as bibliotecas:
Essa validação ocorre antes do processamento dos dados pela aplicação, então só serão processados se todos os campos estiverem válidos.
Sem validação (ANTES):
Imagens
Com validação (DEPOIS):
Imagens