Skip to content

fix: added missing execution_time param for CLI audit command #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 5 commits into from
Oct 30, 2025
Merged

fix: added missing execution_time param for CLI audit command #5563

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6060ac8
fix: added missing execution_time param of CLI audit
makaroni4 Oct 24, 2025
3866b8e
fix: make execution_time a positional argument
makaroni4 Oct 24, 2025
97fb23c
fix: only allow execution_time passed by keyword
makaroni4 Oct 28, 2025
919e76a
fix: restored original params order
makaroni4 Oct 28, 2025
4c9599a
fix: restored original arg order
makaroni4 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sqlmesh/core/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,17 +2247,17 @@ def audit(
self,
start: TimeLike,
end: TimeLike,
execution_time: t.Optional[TimeLike] = None,
Copy link
Copy Markdown
Collaborator

@izeigerman izeigerman Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this moved?

Copy link
Copy Markdown
Contributor Author

@makaroni4 makaroni4 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let's keep execution_time keyword-only 👍

*,
models: t.Optional[t.Iterator[str]] = None,
execution_time: t.Optional[TimeLike] = None,
) -> bool:
"""Audit models.

Args:
start: The start of the interval to audit.
end: The end of the interval to audit.
models: The models to audit. All models will be audited if not specified.
execution_time: The date/time time reference to use for execution time. Defaults to now.
models: The models to audit. All models will be audited if not specified.

Returns:
False if any of the audits failed, True otherwise.
Expand All @@ -2279,6 +2279,7 @@ def audit(
snapshot=snapshot,
start=start,
end=end,
execution_time=execution_time,
snapshots=self.snapshots,
):
audit_id = f"{audit_result.audit.name}"
Expand Down