assets

[djdiptayan1]

Summary by CodeRabbit

Release Notes

• New Features

  • Added "Reset Phase" control action to recalculate phase timing from current duration.
  • Added web app manifest for improved installability and branding.

• Improvements

  • Enhanced paused timer display with fallback duration calculation when timing data is missing or invalid.
  • Implemented debouncing to prevent duplicate rapid control commands; buttons now disable while actions are processing.

• Chores

  • Updated app metadata and viewport configuration.
  • Added ESLint configuration and linting scripts to improve code quality.

[vercel]

@djdiptayan1 is attempting to deploy a commit to the githubcommunitysrm's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The pull request enhances the hackathon event control system by introducing phase-timing utilities, a new RECALCULATE action for resetting timer fields, debounced NEXT_PHASE controls, improved pause/resume timing calculations with fallback logic, and tracking of last control actions. Supporting changes include updated schemas, frontend control UI with flight-state locking, fallback timer calculations when pause data is invalid, ESLint configurations, and web app manifest integration.

Changes

Cohort / File(s)	Summary
Backend Phase Timing & Control backend/controllers/flowController.js, backend/models/dataSchema.js	Added getCurrentPhaseDurationMs utility, NEXT_PHASE debouncing (HTTP 429 on rapid calls), improved PAUSE/RESUME timing with fallback calculations from phase duration, new RECALCULATE action to recompute timer fields, and tracking fields (lastControlAction, lastControlActionAt) for control auditing.
ESLint & Linting Setup backend/eslint.config.cjs, hackclock/eslint.config.mjs, backend/package.json	Added ESLint flat configuration for backend with recommended rules and naming conventions; extended frontend ESLint config with TypeScript/React rule overrides; introduced lint and lint:fix npm scripts and ESLint dependencies.
Frontend Dashboard Control hackclock/app/(admin)/dashboard/page.tsx	Added controlActionInFlight state to prevent concurrent control commands; implemented RECALCULATE action execution with early return on in-flight locks; disabled control buttons during pending operations; updated confirmation modal to include RECALCULATE messaging.
Frontend Timer Fallback Logic hackclock/app/room/[id]/clock/page.tsx, hackclock/app/room/[id]/stage/page.tsx	Modified paused timer initialization to derive fallback time from phase durationMinutes when pausedRemainingMs is missing or invalid; preserved existing behavior for valid remaining-time values.
Metadata & Web App Manifest hackclock/app/layout.tsx, hackclock/public/manifest.json	Added web app manifest reference and multiple icon variants (favicon, sized PNGs) in structured format; introduced viewport export with theme color; added manifest.json defining standalone web app with theme/background colors and icon assets.

Sequence Diagram(s)

sequenceDiagram
    participant User as User<br/>(Dashboard)
    participant Frontend as Frontend<br/>(Dashboard Page)
    participant Backend as Backend<br/>(Flow Controller)
    participant DB as Database<br/>(HackathonSchema)

    User->>Frontend: Click "Reset Phase"<br/>(RECALCULATE)
    activate Frontend
    note over Frontend: Check controlActionInFlight<br/>Set lockKey, set flag=true

    Frontend->>Backend: POST /engine/control<br/>action=RECALCULATE
    activate Backend
    note over Backend: Verify no duplicate<br/>Recompute timer fields<br/>Update status if DRAFT
    Backend->>DB: Update phaseEndTime,<br/>pausedRemainingMs,<br/>lastControlAction
    activate DB
    DB-->>Backend: Confirm update
    deactivate DB
    Backend-->>Frontend: 200 OK + updated state
    deactivate Backend

    Frontend->>Frontend: Update local state<br/>Clear controlActionInFlight flag
    Frontend-->>User: Enable buttons,<br/>refresh display
    deactivate Frontend

Loading

Estimated Code Review Effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly Related PRs

• HackTime DB migration, Soft-Delete sync, and Terminal UI restoration #13: Overlapping edits to backend/controllers/flowController.js and updateRoomState logic for room state handling.
• implement engine controls, dynamic branding, and database fixes #2: Both PRs extend engine control and timing logic in flowController.js and add control-tracking fields to HackathonSchema.
• updated readme files  #11: Builds on the same engineControlExecution and confirmation modal flow in the dashboard component.

Poem

🐰 Hop, hop, hooray! The clock now ticks with wisdom—
Timers fall back, controls stay in sync, no duplicates wreak schism.
Phase resets bloom with the RECALCULATE sprite,
Locked in flight, yet fluid as moonlight. ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'assets' is vague and generic, failing to convey meaningful information about the changeset's primary objectives.	Revise the title to clearly describe the main changes, such as 'Add ESLint configuration, manifest, and phase control enhancements' or similar.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hacktime	Ready	Preview, Comment	Apr 3, 2026 4:11pm
hacktime-backend	Ready	Preview, Comment	Apr 3, 2026 4:11pm

[Copilot]

Pull request overview

This PR updates the hackTime product branding/assets (logos + favicons), adds PWA metadata (manifest + icon metadata), and enhances timer/control behavior across the UI and backend (including a new “Reset Phase/Recalculate” control and improved pause/resume fallbacks).

Changes:

• Add/replace public branding assets (logos, favicons, app icons) and wire them into Next.js metadata + manifest.json.
• Improve paused-timer fallback rendering in stage/clock views when pausedRemainingMs is missing/invalid.
• Add backend support for RECALCULATE, plus NEXT_PHASE debounce tracking, and expose the control in the admin dashboard; add backend lint tooling/config.

Reviewed changes

Copilot reviewed 10 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
hackclock/public/WHITE-ON-BLACK-LOGO.svg	Adds a white-on-black logo asset.
hackclock/public/BLACK-ON-WHITE-LOGO.svg	Adds a black-on-white logo asset.
hackclock/public/PRIMARY-LOGO.svg	Adds primary brand logo asset.
hackclock/public/logo.svg	Replaces the default logo SVG.
hackclock/public/manifest.json	Adds a PWA manifest referencing new app icons.
hackclock/public/favicon.ico	Adds a favicon (currently appears to be PNG data under .ico).
hackclock/public/favicon-16x16.png	Adds 16×16 favicon PNG.
hackclock/public/favicon-32x32.png	Adds 32×32 favicon PNG.
hackclock/public/apple-touch-icon.png	Adds Apple touch icon PNG.
hackclock/public/android-chrome-192x192.png	Adds Android 192×192 icon PNG.
hackclock/public/android-chrome-512x512.png	Adds Android 512×512 icon PNG.
hackclock/eslint.config.mjs	Adds TypeScript/React/Next lint rules (notably naming conventions).
hackclock/app/layout.tsx	Registers manifest + icon metadata + viewport theme color.
hackclock/app/favicon.ico	Adds app-directory favicon (currently appears to be PNG data under .ico).
hackclock/app/room/[id]/stage/page.tsx	Adds paused fallback logic for timer display.
hackclock/app/room/[id]/clock/page.tsx	Adds paused fallback logic for timer display + formatting cleanup.
hackclock/app/(admin)/dashboard/page.tsx	Adds RECALCULATE control, disables actions while a request is in flight.
backend/package.json	Adds lint/lint:fix scripts and ESLint dev dependencies.
backend/eslint.config.cjs	Adds backend ESLint flat config with naming restrictions.
backend/models/dataSchema.js	Adds lastControlAction + lastControlActionAt fields to Hackathon schema.
backend/controllers/flowController.js	Adds RECALCULATE, NEXT_PHASE debounce, and pause/resume fallback duration logic.

Files not reviewed (1)

• backend/package-lock.json: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new @typescript-eslint/naming-convention rule requires all function declarations to be PascalCase. The codebase already has exported functions like minDelay and robots/sitemap that are lower camelCase, so enabling this will introduce widespread lint warnings. Consider allowing camelCase for function (or scoping PascalCase to React components/types only).

Suggested change

	format: ['PascalCase'],
	format: ['camelCase'],

[Copilot]

This ESLint config warns if any function/arrow-function identifier is not PascalCase, but the backend code uses camelCase for controller functions (e.g. deployFlow, updateRoomState). This will generate noisy lint output and make npm run lint hard to use. Recommend removing these no-restricted-syntax selectors or switching the rule to enforce camelCase for non-component functions.

Suggested change

	'no-restricted-syntax': [
	'warn',
	{
	selector: "FunctionDeclaration[id.name!=/^[A-Z][a-zA-Z0-9]*$/]",
	message: 'Function names must be PascalCase like NewFont.',
	},
	{
	selector: "VariableDeclarator[init.type='ArrowFunctionExpression'][id.type='Identifier'][id.name!=/^[A-Z][a-zA-Z0-9]*$/]",
	message: 'Function names must be PascalCase like NewFont.',
	},
	{
	selector: "VariableDeclarator[init.type='FunctionExpression'][id.type='Identifier'][id.name!=/^[A-Z][a-zA-Z0-9]*$/]",
	message: 'Function names must be PascalCase like NewFont.',
	},
	],

[Copilot]

engineControlExecution doesn’t check fetch’s response status. If the API returns a non-2xx (e.g. the backend now returns 429 for rapid NEXT_PHASE, or 400 for invalid RECALCULATE), this code will still mutateAll()/mutateActive() and may clear activeRoomId as if the action succeeded. Capture the response, check res.ok, and surface the error message before mutating state.

[Copilot]

metadata.icons declares /favicon.ico as type: "image/x-icon", but the added public/favicon.ico content looks like PNG data in this PR. Make sure the file format matches the declared type (ICO), or update both the filename and type to image/png.

Suggested change

	{ url: "/favicon.ico", type: "image/x-icon" },
	{ url: "/favicon-16x16.png", sizes: "16x16", type: "image/png" },
	{ url: "/favicon-32x32.png", sizes: "32x32", type: "image/png" },
	{ url: "/android-chrome-192x192.png", sizes: "192x192", type: "image/png" },
	{ url: "/android-chrome-512x512.png", sizes: "512x512", type: "image/png" },
	],
	shortcut: [{ url: "/favicon.ico", type: "image/x-icon" }],
	{ url: "/favicon-32x32.png", sizes: "32x32", type: "image/png" },
	{ url: "/favicon-16x16.png", sizes: "16x16", type: "image/png" },
	{ url: "/favicon-32x32.png", sizes: "32x32", type: "image/png" },
	{ url: "/android-chrome-192x192.png", sizes: "192x192", type: "image/png" },
	{ url: "/android-chrome-512x512.png", sizes: "512x512", type: "image/png" },
	],
	shortcut: [{ url: "/favicon-32x32.png", sizes: "32x32", type: "image/png" }],