Fixes and optimizations to jax-md backend#354
Open
em819 wants to merge 7 commits intoSSAGESLabs:mainfrom
Open
Conversation
…f step fn upon restart
|
Merging to
|
Member
|
Hi @em819. Thank you interest and for the contribution to the repo! I'm sorry we've been slow to reply here. I'll try to review the code soon and provide any appropriate feedback. |
Author
|
Hey @p-zubieta , |
Author
|
Hi there @p-zubieta . Just wanted to ask if I should take action in resolving the conflicts and merging or you prefer to do it on your end? Don't want to inappropriately interfere with the pull request. |
Member
|
I was thinking on doing it on our end, cherry-picking your commits. We did some internal changes to allow for the inclusion of additional data into Snapshots a bit easier and want to move this PR on top of those. |
Author
|
Sure thing, sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have performed following fixes concerning the jax-md backend of PySAGES: