Skip to content

🐛 Push hero further out of view when the scroll arrow is clicked #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designbyalex merged 3 commits into from
Aug 6, 2026
Merged

🐛 Push hero further out of view when the scroll arrow is clicked #4969

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0d8ab5
🐛 Push hero further out of view when the scroll arrow is clicked
designbyalex Aug 6, 2026
f2402f1
📝 Fix stale comment on the hero scroll arrow
designbyalex Aug 6, 2026
519dd62
🧹 Collapse the double negative in the scroll offset
designbyalex Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/blocks/v3/heroBox/heroBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ export const V3HeroBox = ({ data, priority = false }) => {
type="button"
aria-label="Scroll to content"
onClick={(e) => {
// Scroll so the arrow ends up 10% of the viewport height down from
// the top of the screen, pulling the hero up out of the way.
// Scroll the arrow 10% of the viewport height past the top of the
// screen, clearing the hero out of the way.
const { top } = e.currentTarget.getBoundingClientRect();
window.scrollTo({
top: window.scrollY + top - window.innerHeight * 0.1,
top: window.scrollY + top + window.innerHeight * 0.1,
behavior: "smooth",
});
}}
Expand Down
Loading