Update for newer versions of Python, NumPy#106
Open
WardLT wants to merge 4 commits intoSUNCAT-Center:masterfrom
Open
Update for newer versions of Python, NumPy#106WardLT wants to merge 4 commits intoSUNCAT-Center:masterfrom
WardLT wants to merge 4 commits intoSUNCAT-Center:masterfrom
Conversation
sklearn is just a placeholder for scikit-learn and not an actual Python package
NumPy must have changed how arrays of sequences are created at somepoint in the past. I cannot find it in the change log, but the change I suggest should work across numpy versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues that CatKit has with newer versions of Python and NumPy
I also fixed a few other bugs:
isto test for equality