Open
Conversation
✅ Deploy Preview for sustech-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
添加的依赖为: + "dom-to-image-more": "^3.5.0",
+ "qrcodejs2": "^0.0.2"稍晚一些我改一下ui组件以及看下能不能更新到其他的包 |
Member
|
iPhone 上 Safari 不能使用 此外引入 Tailwind CSS 或者 UnoCSS 会不会让样式代码短一些 不嫌麻烦的话建议用 TypeScript 写? |
sghng
requested changes
Apr 23, 2025
Member
sghng
left a comment
There was a problem hiding this comment.
除此之外,tsconfig 里面也可以配置 globals
{
"compilerOptions": {
...
},
"globals": {
"browser": true
}
}
不太清楚配置了 tsconfig 之后还需不需要 eslint 里面再配置一次 globals
Member
There was a problem hiding this comment.
ESLint 配置不需要手动加这么多 globals,只需要这样即可:
languageOptions: {
globals: {
...globals.browser,
},
},
需要安装 globals 作为依赖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本PR实现了分享卡片功能的全面优化,主要包括:
原本采用 html2canvas,实际采用 dom-to-image-more
使用指南:
1.选择对应文字会在正上方显示 复制文字 和 分享 两个按钮。
2.点击复制复制文字,点击分享弹出卡片预览框
测试: Windows 10, MS Edge 与 Google Chrome