Skip to content

feat(VectorLayer): Make placeBelow optional #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 2 commits into from
Mar 17, 2026
Merged

feat(VectorLayer): Make placeBelow optional #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7298ad0
Add test case
awesomephant Mar 17, 2026
e9aeab9
Implement feature
awesomephant Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions components/src/maplibre/VectorLayer/VectorLayer.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,26 @@
</DesignTokens>
</Story>

<Story asChild name="feat/341">
<DesignTokens theme="light">
<div class="container">
<Map showDebug={true} style={SWRDataLabLight({ places: { showLabels: false } })}>
<GeoJsonSource id="demo" data={SamplePoints as GeoJSON} attribution="Demo attribution" />
<VectorLayer
sourceId="demo"
id="circles"
type="circle"
paint={{
'circle-radius': 12,
'circle-color': 'red'
}}
/>
<AttributionControl position="bottom-left" />
</Map>
</div>
</DesignTokens>
</Story>

<Story asChild name="Filter">
<DesignTokens theme="light">
<div class="controls">
Expand Down
15 changes: 8 additions & 7 deletions components/src/maplibre/VectorLayer/VectorLayer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@
sourceId,
sourceLayer,
filter,
visible = true,
placeBelow = 'label-place-major-city',
placeBelow,
type,
paint,
layout,
Expand Down Expand Up @@ -80,15 +79,17 @@
$effect(() => {
if (map && styleLoaded) {
const style = map.getStyle();
beforeId = style.layers.find((l) => {
return l.id === placeBelow;
})?.id;
beforeId = placeBelow
? style.layers.find((l) => {
return l.id === placeBelow;
})?.id
: undefined;
}
});

$effect(() => {
if (map && styleLoaded && beforeId) {
map.addLayer(layerSpec, beforeId);
if (map && styleLoaded) {
beforeId ? map.addLayer(layerSpec, beforeId) : map.addLayer(layerSpec);
}
});

Expand Down