Add cbs branching for compact table problems.#1
Open
CarolineSabourin-Jean wants to merge 1 commit intoSaGagnon:upirfrom
Open
Add cbs branching for compact table problems.#1CarolineSabourin-Jean wants to merge 1 commit intoSaGagnon:upirfrom
CarolineSabourin-Jean wants to merge 1 commit intoSaGagnon:upirfrom
Conversation
SaGagnon
reviewed
Jun 8, 2019
| auto SendMarginal = [this](unsigned int prop_id, unsigned int var_id, | ||
| int val, double dens) { | ||
| if (!varIdToPos.isIn(var_id)) return; | ||
|
|
Owner
There was a problem hiding this comment.
Avez-vous trouvé pourquoi il y a des variables dans le propagateur qui ne se retrouvent pas dans le brancher? J'avais ajouté ce fix pour cette raison et je ne sais pas si c'est un comportement normal.
Author
There was a problem hiding this comment.
Non on n'a pas trouvé, désolée :(
| // We can change rho's value. Actually, there is no memory exception | ||
| // with rho = 1. But with other values of rho, there is a memory | ||
| // exception for some crossword problems. | ||
| float rho = 1; |
Owner
There was a problem hiding this comment.
Gilles m'a dit qu'il y avait des fuites de mémoire avec rho < 1. Je vais regarder ça.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.