Open
Conversation
* requires new unit to belong to a unit_class
Sab44
force-pushed
the
recorder-unit-migration-poc
branch
from
512a574 to
1a4ca1b
Compare
Sab44
force-pushed
the
recorder-unit-migration-poc
branch
from
78f11e1 to
27a39ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for detecting a unit migration when compiling 5-min aggregate statistics.
It will detect a unit migration under the following conditions:
In that case it will drop old states that have the old unit. This is one-time only by keeping track of the entity id. If it does happen again the same warnings as before will be fired.