Skip to content

Fix invisible names#640

Merged
7w1 merged 1 commit intoSableClient:devfrom
nushea:fix-blanks
Apr 5, 2026
Merged

Fix invisible names#640
7w1 merged 1 commit intoSableClient:devfrom
nushea:fix-blanks

Conversation

@nushea
Copy link
Copy Markdown
Contributor

@nushea nushea commented Apr 5, 2026

Description

Small change to attempt to default to the right name so that they do not show as being blank

Had to be a hard list because there does not seem to be a list of characters that are supposed to be blank within the \p type

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

A million monkeys spent a million years typing out the implementation

@nushea nushea requested review from 7w1 and hazre as code owners April 5, 2026 02:49
Copy link
Copy Markdown
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A million monkeys spent a million years typing out the implementation

Impressive monkeys

@7w1 7w1 added this pull request to the merge queue Apr 5, 2026
Merged via the queue into SableClient:dev with commit 0ae47b6 Apr 5, 2026
12 checks passed
@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Apr 5, 2026

A million monkeys spent a million years typing out the implementation

Impressive monkeys

it was quite a challenge teaching them regex, a lot of trouble getting them to stop writing all the works of Shakespear

@nushea nushea deleted the fix-blanks branch April 5, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants