Fix/company card routing student layout#325
Conversation
…e, fix active route highlighting for sub-routes
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #128
Problem
On
/student/companies, clicking a CompanyCard or YCCard alwaysrouted to the public page (
/companies/:slugor/yc/:slug),throwing students out of the student layout context.
Root Cause
CompanyCard and YCCard had hardcoded links and were unaware of
the current layout context, unlike InterviewCompanyCard which
already handled this correctly via an
insideLayoutprop.Fix
Passed
insideLayoutprop to bothCompanyCardandYCCard,same pattern already used by
InterviewCompanyCard. When insidethe student layout, links are prefixed with
/student.CompanyCard→/student/companies/:sluginside layoutYCCard→/student/yc/:sluginside layoutFiles Changed
client/src/module/student/companies/CompanyListPage.tsxNote
Unable to demonstrate via video as no company data is available
in the dev environment. Happy to record once data is seeded or
maintainer can verify directly on staging.