refactor: improve error handling by logging errors in catch blocks#329
refactor: improve error handling by logging errors in catch blocks#329ronak-ravtode wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReplaces 15 silent ChangesError Handling Improvements
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
i am GSSOC'26 contrituber so kindly add tags according to you before merge. |
|
There is some conflict it can you look it into it |
|
Duplicate PR |
|
give me pr number of my duplicate pr, i didn't find it |
Issue #320
Summary
Fixed 16+ empty
.catch()blocks across the codebase that were silently swallowing errors without logging or user feedback. This was causing poor UX (users seeing broken/frozen UI with no explanation) and making debugging nearly impossible since errors vanished with no trace.Changes
client/src/module/student/profile/StudentProfilePage.tsxconsole.error("Failed to load job preferences:", err)client/src/module/student/profile/StudentProfilePage.tsxclient/src/module/student/python/lib/python-engine.tsconsole.error("Failed to preload Pyodide:", err)client/src/module/student/python/lib/python-engine.tsconsole.error("Failed to reset Python stdout/stderr:", err)client/src/module/student/skill-verification/SkillTestPage.tsxconsole.error("Failed to exit fullscreen:", err)client/src/module/student/interview-prep/interviewProgress.tsconsole.error("Failed to update visit progress:", err)client/src/module/student/interview-prep/interviewProgress.tsconsole.error("Failed to sync visit progress:", err)client/src/module/student/interview-prep/InterviewQuestionPage.tsxconsole.error("Failed to toggle question completion:", err)client/src/module/student/companies/CompanyListPage.tsxconsole.error("Failed to load cities:", err)client/src/module/student/companies/CompanyDetailPage.tsxconsole.error("Failed to load reviews:", err)client/src/module/scraped-jobs/ScrapedJobsPage.tsxconsole.error("Failed to load job sources:", err)client/src/module/recruiter/applications/ApplicationDetail.tsxconsole.error("Failed to load verified skills:", err)client/src/module/admin/AdminSubscribersPage.tsxconsole.error("Failed to load subscribers:", err)client/src/lib/milestone.utils.tsconsole.error("Failed to report milestone:", err)client/src/hooks/useFaceDetection.tsconsole.error("Failed to start video playback:", err)client/src/lib/auth.store.tsconsole.error("Failed to clear session on logout:", err)How to test
Screenshots
No UI changes - this is a backend/logging fix. Error messages now appear in the browser console for debugging, but no user-facing UI was modified.
Summary by CodeRabbit