Optimize Rich Live line-count hot path + document long-response fallback#134
Merged
Conversation
Follow-up to the long-response Rich Live fallback (PR #133). ui/render.py: _rendered_line_count now uses a cheap per-line wrap estimate to short-circuit the expensive full console.render_lines() measurement while a response stays comfortably under the limit. Normal responses no longer pay an extra full Markdown re-render on every streamed chunk (was O(n^2) on the hot path); the precise render only runs as output nears the fallback limit. On render failure it now falls back to the cheap estimate instead of 0 so oversized content still triggers the plain-streaming fallback. Docs: document the automatic per-response plain-streaming fallback (wrap- / terminal-height aware) across README News, docs/news.md, features.md, advanced.md, and the 7 i18n READMEs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the long-response Rich Live fallback (PR #133).
ui/render.py: _rendered_line_count now uses a cheap per-line wrap estimate to short-circuit the expensive full console.render_lines() measurement while a response stays comfortably under the limit. Normal responses no longer pay an extra full Markdown re-render on every streamed chunk (was O(n^2) on the hot path); the precise render only runs as output nears the fallback limit. On render failure it now falls back to the cheap estimate instead of 0 so oversized content still triggers the plain-streaming fallback.
Docs: document the automatic per-response plain-streaming fallback (wrap- / terminal-height aware) across README News, docs/news.md, features.md, advanced.md, and the 7 i18n READMEs.