Separated check_name into org and schema functions#1328
Merged
andrewelamb merged 3 commits intodevelopfrom Feb 25, 2026
Merged
Conversation
thomasyu888
reviewed
Feb 24, 2026
Member
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM, Ill leave it up to @linglp as final review.
linglp
approved these changes
Feb 25, 2026
Contributor
linglp
left a comment
linglp
left a comment
There was a problem hiding this comment.
LGTM! Just two minor comments.
| parts = name.split(".") | ||
| for part in parts: | ||
| if not re.match(r"^([A-Za-z])([A-Za-z]|\d|)*$", part): | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
Nit: I think the error message here can be more descriptive:
raise ValueError(
f"Invalid schema name '{name}'. Each part must start with a letter "
f"and contain only letters and numbers. "
f"Example: 'my.schema.name' or 'MySchema123'"
)
Contributor
|
@andrewelamb could you take a look at the sonar cloud error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In Synapse JSONSchema and Organizations have similar but different restrictions on their names. In the Synapse client, we are treating them as identical, and have one function
_check_namefor both.Solution:
There are now two separate functions for testingJSON Schema and organization names.