Prevent unsafe retries for ambiguous writes - #2
Merged
Conversation
This was referenced Jul 10, 2026
SahirVhora
marked this pull request as ready for review
July 10, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AmbiguousWriteErrorwhen a write receives a retryable server response or loses its response to a network errorWhy
The shared retry loop previously replayed POST, PATCH, and DELETE requests. If SuccessFactors committed a mutation but its response was lost, replaying the request could duplicate the change or turn a successful create into a misleading duplicate failure.
Downstream callers can now reconcile target state before deciding whether a write should be retried.
Validation
pytest: 175 passed, 2 skippedgit diff --check: passedThe repository-wide mypy run still reports existing issues in unrelated modules and missing third-party stubs.