fix: agentic ask drops assistant turns when response persistence fails once#876
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: agentic ask drops assistant turns when response persistence fails once#876sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing as duplicate of #877. The nightly parser has been updated to semantic-dedupe same-root-cause candidates before launching fix agents, including different titles/wrappers around the same failing callback contract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
store.AddMessageerror from theterm-llm askresponse-completed persistence callback instead of reporting success after a failed assistant-message write.AddMessage: the engine now treats the response callback as unhandled and redelivers the assistant throughTurnCompletedCallbackalongside the tool result.Why this is high-value
Agentic
askpersists the assistant message before tool execution so sessions survive tool failures. When that write failed transiently, the callback still returned nil, causing the engine to omit the assistant from the later turn callback. That silently corrupted saved sessions by keeping tool results without the assistant/tool-call message that produced them.Returning the write error preserves the existing engine recovery contract: a failed response callback means the assistant is included in the turn-completed messages and can be persisted on the retry path.
Validation
go test ./cmd -run TestAskPersistenceRetriesAssistantThroughTurnCallbackWhenResponsePersistenceFails -count=1go build ./...go test ./...git diff --check