Fix test#3
Open
Sameerlite wants to merge 1 commit intolitellm_litellm_team-model-group-name-routing-fixfrom
Open
Fix test#3Sameerlite wants to merge 1 commit intolitellm_litellm_team-model-group-name-routing-fixfrom
Sameerlite wants to merge 1 commit intolitellm_litellm_team-model-group-name-routing-fixfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| # Verify the value was overridden | ||
| assert ( | ||
| new_value == test_value | ||
| ), f"Failed to override {name} with environment variable. Expected {test_value}, got {new_value}" |
There was a problem hiding this comment.
Test fails for non-overridable hardcoded numeric constant
Medium Severity
DEFAULT_HEALTH_CHECK_STALENESS_MULTIPLIER in constants.py is hardcoded to 2 with no os.getenv call. The test iterates over all uppercase numeric constants and asserts each can be overridden via an environment variable. Since this constant doesn't read from any env var, reloading the module will always yield 2, causing the assertion to fail when it expects 3.
Sameerlite
pushed a commit
that referenced
this pull request
Apr 1, 2026
docs: sidebar QA fixes and index updates
Sameerlite
pushed a commit
that referenced
this pull request
Apr 1, 2026
- Skip short-circuit for providers that have a BaseAnthropicMessagesConfig (bedrock, vertex_ai, azure_ai, anthropic) — they use the agentic loop which includes a follow-up LLM synthesis step. Short-circuiting would return raw search text instead of an LLM-synthesized answer. - Add fallback to litellm.get_llm_provider() for custom_llm_provider derivation when litellm_params is overwritten by kwargs. - Add test for bedrock guard. Addresses Greptile review comments #3 and #4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes
Note
Low Risk
Low risk: test-only change, but it reloads
litellm.constantsrepeatedly and could add some runtime/flakiness in CI if constants have import-time side effects.Overview
Adds
test_all_numeric_constants_can_be_overridden, which introspectslitellm.constantsfor all uppercaseint/floatvalues, discovers their actual env var names by AST-parsingconstants.py(includingget_env_int/os.getenv), and asserts each constant changes after setting the env var and reloading the module.Written by Cursor Bugbot for commit bd59139. This will update automatically on new commits. Configure here.