This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Use generic in the platform name instead of noarch#141
Open
akosthekiss wants to merge 1 commit intoSamsung:masterfrom
Open
Use generic in the platform name instead of noarch#141akosthekiss wants to merge 1 commit intoSamsung:masterfrom
akosthekiss wants to merge 1 commit intoSamsung:masterfrom
Conversation
libtuv-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
Contributor
Author
|
Fallout from jerryscript-project/iotjs#1947 (review) |
Contributor
|
LGTM, good idea, may I also reintroduce the generic profile that enable most modules (previously named full) ? |
Contributor
Author
|
Please, note that this is only a patch in libtuv, which will have to be followed up with a similar PR in iotjs. Modules and the like are in the territory of iotjs, so this will have to be discussed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libtuv-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu