Skip to content

configury: disable Fortran unless --enable-fortran#1193

Merged
davidozog merged 1 commit into
Sandia-OpenSHMEM:mainfrom
davidozog:pr/disable_fortran_by_default
Mar 18, 2025
Merged

configury: disable Fortran unless --enable-fortran#1193
davidozog merged 1 commit into
Sandia-OpenSHMEM:mainfrom
davidozog:pr/disable_fortran_by_default

Conversation

@davidozog
Copy link
Copy Markdown
Member

Configure such that the Fortran API is always disabled unless explicitly enabled.

Fortran was deprecated in OpenSHMEM v1.4 and removed in v1.5, and this seems to cause problems with updating the sos Spack package, at least for me.

Closes #1184

@davidozog davidozog self-assigned this Mar 17, 2025
Copy link
Copy Markdown
Collaborator

@bcmIntc bcmIntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will you also change test-sos' usage?

@davidozog
Copy link
Copy Markdown
Member Author

Looks good, will you also change test-sos' usage?

We already disabled fortran by default in tests-sos from a user request, but deferred/forgot to do the same in SOS. I'm glad you asked, there was a typo in the help string with I tacked on to this PR:
openshmem-org/tests-sos#53

in commit openshmem-org/tests-sos@a46cb3a

@davidozog davidozog requested a review from abrooks98 March 18, 2025 13:02
@davidozog davidozog merged commit b4d44b4 into Sandia-OpenSHMEM:main Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Fortran Support

4 participants